johannchopin / gitmoji-browser-extension

The Gitmoji browser extension to easily search and copy gitmojis 😜
MIT License
81 stars 9 forks source link

✨ Show description when hovering over gitmoji #55

Closed mirror-kt closed 3 years ago

mirror-kt commented 3 years ago

Hello Team πŸ‘‹

Describe the feature that you want see I want the description on gitmoji.dev to be shown as an overlay when hovering over gitmoji in list.

Example

When hovering the emoji :art:, the description Improve structure / format of the code. is shown.

johannchopin commented 3 years ago

Hey @mirror-kt πŸ‘‹

This would be really a nice and helpful improvement to the extension. Do you planned to take care of it? If you don't have the time I could spent some time on it πŸ‘

I guess we could just make the description appear bellow the gitmoji's row on hover but also on focus since the extension should also be used with the tab key.

mirror-kt commented 3 years ago

If I could write svellte, I did it myself, but I can't write much😭.

So, could you take care of it?

P.S. focus a good idea! I'm looking forward to future development!

johannchopin commented 3 years ago

I implemented it in #61 so feel free to checkout this branch and see the result by running yarn start or npm run start and give a feedback πŸ‘

mirror-kt commented 3 years ago

γ‚Ήγ‚―γƒͺγƒΌγƒ³γ‚·γƒ§γƒƒγƒˆ 2021-02-02 20 57 26 It seems that the description of the bottom line is displayed outside the frame πŸ‘€.

johannchopin commented 3 years ago

Yes true but IMHO it isn't worth the effort to implement this feature. Most of this extension users already now which gitmoji they want and use the search input. So in mosts cases the needed gitmoji is not at the end of the list. If it is you can then use your arrow-down key or scroll a little. In know it's not the best user-friendly implementation but it's a good start. Is it ok then to just leave it like it is? πŸ‘

mirror-kt commented 3 years ago

I see, that's OK! LGTM, thanksπŸ˜„