search

johannes-mueller / dired-gitignore.el

dired minor mode to ignore files that are to be ignored by git
GNU General Public License v3.0
21 stars 3 forks source link

backtick substitution fail for fish shell #8

Closed teeann closed 1 year ago

teeann commented 1 year ago

First, thank you for this helpful Emacs package! Currently, the backtick substitution in dired-gitignore--files-to-be-ignored does not work for Fish shell. My suggestion is to replace git check-ignore `ls -A1` with git check-ignore * instead.

johannes-mueller commented 1 year ago

Thanks for reporting this, @teeann. Unfortunately your proposal using * does not work as it wouldn't affect the dotfiles. That is the reason why I am using ls -A1 in the first place.

However, the $(ls -A1) notation seems to work in fish.

Please reopen if it still does not work.

johannes-mueller commented 1 year ago

Well, as it turns out the $(...) notation was introduced in fish not before version 3.4.0. All the solutions I could think of making it work for older versions of fish would require to make things riskily complex. So I would prefer not to support fish < 3.4.0.