johannesboyne / gofakes3

A simple fake AWS S3 object storage (used for local test-runs against AWS S3 APIs)

MIT License

361 stars 84 forks source link

S3 test check #15

Closed johannesboyne closed 5 years ago

johannesboyne commented 5 years ago

Checking to keep or remove the S3-test suite https://github.com/gaul/s3-tests

johannesboyne commented 5 years ago

FAILED (SKIP=55, errors=454, failures=23)

Let's see whether it makes sense to keep this inside the repository, or simply removing it. I have to dive into the errors but as there are so many, I assume it will just be a configuration issue right now.

gaul commented 5 years ago

s3-tests vastly improved S3Proxy compatibility so I recommend using it for gofakes3. However it is hard to work with the upstream project and I have maintained my fork for years. Further they are porting to boto3 which seems to change everything and are not merging new pull requests to avoid conflicts. You are welcome to use my fork but I periodically rewrite history when I track upstream changes.

shabbyrobe commented 5 years ago

FAILED (SKIP=55, errors=454, failures=23)

Do any of them pass? :laughing:

@gaul, would you recommend we use your fork or the original repo?

gaul commented 5 years ago

I recommend creating a new fork of the original repo but using my fork as a reference since it shows how to disable failing tests via attributes. There is nothing special about my fork and I hope that upstream merges all my pull requests some day.

codecov-io commented 5 years ago

Codecov Report

Merging #15 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #15   +/-   ##
======================================
  Coverage    64.4%   64.4%           
======================================
  Files          10      10           
  Lines         500     500           
======================================
  Hits          322     322           
  Misses        148     148           
  Partials       30      30

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3053187...f9165a1. Read the comment docs.