Closed cure closed 4 years ago
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells
Merging #46 into master will decrease coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 66.69% 66.68% -0.02%
==========================================
Files 27 27
Lines 2411 2410 -1
==========================================
- Hits 1608 1607 -1
Misses 567 567
Partials 236 236
Impacted Files | Coverage Δ | |
---|---|---|
gofakes3.go | 67.52% <ø> (-0.06%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e89baa3...ee074e4. Read the comment docs.
Hi @cure,
And thanks a lot for your contribution!
I am wondering, whether we should move the code instead of deleting it in order to keep returning Last-Modified
just with the correct time instead of a newly calculated one - WDYT?
Hi @johannesboyne, I'm not sure I understand the question. The Last-Modified header will still be present in the response to the GET or HEAD request; it's populated from the object Metadata, where it was stored by the metadataHeaders
function. Does that sound correct?
Ah, you're right! Perfect.
in GET and HEAD calls, use the stored value instead.