search

johannesboyne / gofakes3

A simple fake AWS S3 object storage (used for local test-runs against AWS S3 APIs)
MIT License
358 stars 81 forks source link

Support for chunk upload signatures #50

Closed leoleoasd closed 3 years ago

leoleoasd commented 3 years ago

Fixes #49

johannesboyne commented 3 years ago

Hi @leoleoasd, THANK! you for the contribution.

Seems like a great addition to support AWS Signature Version 4 Chunk Upload and by taking a first read through the code it looks good and straight forward. IMO, the newly introduced file chunk.go could easily get a nice test case. This will make codecov happy ;-) See https://github.com/johannesboyne/gofakes3/blob/master/uploader_test.go#L10 for an example. What do you think?

leoleoasd commented 3 years ago

Okay, sure do!

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

leoleoasd commented 3 years ago

Covered chunk.go 100%