search

johannesboyne / gofakes3

A simple fake AWS S3 object storage (used for local test-runs against AWS S3 APIs)
MIT License
361 stars 84 forks source link

Multipart uploads fail with minio client due to mismatched etags #51

Closed tasdomas closed 3 years ago

tasdomas commented 3 years ago

I was trying to use gofakes3 to test the use of the https://pkg.go.dev/github.com/minio/minio-go/v7#Client in a package. However, I've found that multipart uploads fail due to a failing test here.

The condition fails because inPart.ETag (from the xml doc) is not quoted and upPart.ETag (from the header) is.

Even though RFC7232 specifies that etags are always quoted, aws s3 docs are not clean on whether the etag should be quoted in the xml document.

johannesboyne commented 3 years ago

Hi @tasdomas Thank's a lot for the contribution, seems to be a relevant change. Thanks!