johannesboyne / gofakes3

A simple fake AWS S3 object storage (used for local test-runs against AWS S3 APIs)

MIT License

358 stars 81 forks source link

Add test for unmarshall to bolt object before listing. #58

Closed ocakhasan closed 3 years ago

ocakhasan commented 3 years ago

Hello,

Thank you for accepting my previous PR. Like you suggested at the end, I tried to add a small test case which shows that after listing objects, the object sizes are correct.

Also I figured that, gofakes3 does not show real modification time when ListBucket is called. So I tried to solve this problem with,

Put modification time into boltObject when putObject is called.
Then unmarshall it when listing is called.

Then, we can see the real times which shows the time object is uploaded.

codecov-commenter commented 3 years ago

Codecov Report

Merging #58 (1818715) into master (e0d4973) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   67.89%   67.89%           
=======================================
  Files          28       28           
  Lines        2492     2492           
=======================================
  Hits         1692     1692           
  Misses        564      564           
  Partials      236      236

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0d4973...1818715. Read the comment docs.