search

johannesboyne / gofakes3

A simple fake AWS S3 object storage (used for local test-runs against AWS S3 APIs)
MIT License
361 stars 84 forks source link

Content-Disposition metadata is ignored when creating object #61

Closed hlubek closed 2 years ago

hlubek commented 2 years ago

The fake S3 server should store the Content-Disposition header sent by the client in the object metadata. It is currently filtered (only Content-Type can be set).

johannesboyne commented 2 years ago

Hi @hlubek thanks a lot for your contribution! To be honest, I first needed to check the Content-Disposition header, as I never used it ;-)

One aspect one could add to the test case is setting Content-Type and Content-Disposition in combination. But the code executing should not cause any troubles. Thus LGTM!