Closed elgohr closed 1 year ago
Thanks a lot for the test-case! As it currently fails (obviously), it would be best to also include the implementation! I have not looked at the implementation details behind the tagging, but it looks straight forward here https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObjectTagging.html
PUT /{Key+}?tagging&versionId=VersionId HTTP/1.1
Host: Bucket.s3.amazonaws.com
Content-MD5: ContentMD5
x-amz-sdk-checksum-algorithm: ChecksumAlgorithm
x-amz-expected-bucket-owner: ExpectedBucketOwner
x-amz-request-payer: RequestPayer
<?xml version="1.0" encoding="UTF-8"?>
<Tagging xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
<TagSet>
<Tag>
<Key>string</Key>
<Value>string</Value>
</Tag>
</TagSet>
</Tagging>
The implementation would be probably as follows:
gofakes3.go
that implements the tagging correctlyAre you open to that?
Just adding the failing test-case could cause other implementations to fail if they check libs for test-cases.
So how would you put that into https://github.com/johannesboyne/gofakes3/blob/master/backend.go#L133 ? There're a few concepts, like the homebrewn router, that take me time to understand. I guess it would be faster when you would give it a try.
Worked on in PR #75
Would have been great if you cherry-picked my commit - but I'm happy anyway for the topic to move on
At the moment the body is changed when putting a tag. I just created the test . Could you please have a look at the implementation?