search

johannesboyne / gofakes3

A simple fake AWS S3 object storage (used for local test-runs against AWS S3 APIs)
MIT License
358 stars 81 forks source link

Fix auto bucket creation option #73

Closed aidilfbk closed 1 year ago

aidilfbk commented 1 year ago

Modify WithAutoBucket method to respect the enabled argument.

Previously, calling the method would cause buckets to always be automatically created, regardless of the provided argument.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov-commenter commented 1 year ago

Codecov Report

Merging #73 (fc8eda1) into master (32fb85c) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   66.60%   66.60%           
=======================================
  Files          28       28           
  Lines        2590     2590           
=======================================
  Hits         1725     1725           
  Misses        613      613           
  Partials      252      252
Impacted Files Coverage Δ
option.go 72.72% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.