Open johannesboyne opened 1 year ago
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
8.1% Duplication
Attention: 21 lines
in your changes are missing coverage. Please review.
Comparison is base (
c55a48f
) 65.94% compared to head (940f235
) 65.74%.
Files | Patch % | Lines |
---|---|---|
gofakes3.go | 56.25% | 7 Missing and 7 partials :warning: |
routing.go | 69.23% | 4 Missing :warning: |
backend/s3afero/single.go | 33.33% | 2 Missing :warning: |
backend/s3afero/multi.go | 66.66% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@elgohr see this implementation as a first step, your test case is running with this but might be good to check out your real-world case against this to see, whether it actually works and behaves as expected.
Failed conditions
6.9% Duplication on New Code (required ≤ 3%)
This fixes issue #72 and builds on PR #71
If the general implementation would work like this as expected, we could extend the test cases a bit and then merge this PR.