johannesboyne / gofakes3

A simple fake AWS S3 object storage (used for local test-runs against AWS S3 APIs)
MIT License
358 stars 81 forks source link

Initiate work on PutObjectTagging ref PR#71 and issue #72 #75

Open johannesboyne opened 1 year ago

johannesboyne commented 1 year ago

This fixes issue #72 and builds on PR #71

If the general implementation would work like this as expected, we could extend the test cases a bit and then merge this PR.

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.1% 8.1% Duplication

codecov-commenter commented 1 year ago

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (c55a48f) 65.94% compared to head (940f235) 65.74%.

Files Patch % Lines
gofakes3.go 56.25% 7 Missing and 7 partials :warning:
routing.go 69.23% 4 Missing :warning:
backend/s3afero/single.go 33.33% 2 Missing :warning:
backend/s3afero/multi.go 66.66% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #75 +/- ## ========================================== - Coverage 65.94% 65.74% -0.21% ========================================== Files 28 28 Lines 2693 2744 +51 ========================================== + Hits 1776 1804 +28 - Misses 651 666 +15 - Partials 266 274 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

johannesboyne commented 1 year ago

@elgohr see this implementation as a first step, your test case is running with this but might be good to check out your real-world case against this to see, whether it actually works and behaves as expected.

sonarcloud[bot] commented 7 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud