johannesboyne / gofakes3

A simple fake AWS S3 object storage (used for local test-runs against AWS S3 APIs)
MIT License
361 stars 84 forks source link

Add Content-Encoding to metadata headers #79

Closed csw closed 1 year ago

csw commented 1 year ago

gofakes3 was not preserving the Content-Encoding header, meaning that clients would get raw gzipped data in GetObject responses instead of the expected decompressed data when it was stored with Content-Encoding: gzip. With this change, it matches the behavior of S3 itself.

codecov-commenter commented 1 year ago

Codecov Report

Merging #79 (fb90c9b) into master (f6a8a9a) will increase coverage by 0.03%. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   66.67%   66.71%   +0.03%     
==========================================
  Files          28       28              
  Lines        2587     2590       +3     
==========================================
+ Hits         1725     1728       +3     
  Misses        610      610              
  Partials      252      252              
Impacted Files Coverage Δ
cors.go 75.00% <ø> (ø)
gofakes3.go 64.03% <100.00%> (+0.18%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

johannesboyne commented 1 year ago

Thanks @csw great PR!