johannesboyne / gofakes3

A simple fake AWS S3 object storage (used for local test-runs against AWS S3 APIs)
MIT License
358 stars 81 forks source link

Add MultipartBackend interface to support overriding the multipart upload behaviour #83

Closed ChrisSchinnerl closed 1 year ago

ChrisSchinnerl commented 1 year ago

This PR adds support for implementation the optional MultipartBackend interface to avoid the in-memory multipart uploader and instead use a custom one.

I have to admit I accidentally opened this PR and the Copy PR on this repo instead of our fork but I thought it might be a good addition anyway.

codecov-commenter commented 1 year ago

Codecov Report

Merging #83 (737ad23) into master (42c772b) will decrease coverage by 0.14%. The diff coverage is 62.33%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   65.93%   65.79%   -0.14%     
==========================================
  Files          28       28              
  Lines        2677     2681       +4     
==========================================
- Hits         1765     1764       -1     
- Misses        647      649       +2     
- Partials      265      268       +3     
Files Changed Coverage Δ
backend.go 91.30% <ø> (ø)
gofakes3.go 65.15% <46.66%> (+0.35%) :arrow_up:
uploader.go 84.61% <66.12%> (-3.91%) :arrow_down:
sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

shabbyrobe commented 1 year ago

Looks great! Thank you!