johannesboyne / gofakes3

A simple fake AWS S3 object storage (used for local test-runs against AWS S3 APIs)
MIT License
361 stars 84 forks source link

Fix startAfter when object is not present #88

Closed Alfus closed 8 months ago

Alfus commented 9 months ago

The iterator always seeks to the value >= the entry, so the marker should only be skipped when it actually exists. Otherwise the iterator is already pointing at the next value.

See https://github.com/johannesboyne/gofakes3/issues/87

codecov-commenter commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f7e9c41) 65.92% compared to head (b359e41) 65.94%.

Files Patch % Lines
backend/s3mem/backend.go 85.71% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #88 +/- ## ========================================== + Coverage 65.92% 65.94% +0.02% ========================================== Files 28 28 Lines 2691 2693 +2 ========================================== + Hits 1774 1776 +2 - Misses 650 651 +1 + Partials 267 266 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud