search

johannesboyne / gofakes3

A simple fake AWS S3 object storage (used for local test-runs against AWS S3 APIs)
MIT License
358 stars 81 forks source link

docs: update README.md with host bucket example #92

Closed armsnyder closed 2 months ago

armsnyder commented 3 months ago

The SDK V2 example in the readme did not work for me. The readme suggestion to use WithS3ForcePathStyle only works with SDK V1. I had to make these changes to the V2 example.

  1. Configure gofakes3 to use host bucket
  2. Configure the test server with a custom dialer that strips the bucket subdomain before dialing

Related to #32

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.99%. Comparing base (99de01e) to head (9212989).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #92 +/- ## ======================================= Coverage 65.99% 65.99% ======================================= Files 28 28 Lines 2697 2697 ======================================= Hits 1780 1780 Misses 651 651 Partials 266 266 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

johannesboyne commented 2 months ago

Thanks @armsnyder for the contribution!