johannesboyne / gofakes3

A simple fake AWS S3 object storage (used for local test-runs against AWS S3 APIs)
MIT License
358 stars 81 forks source link

Add rudimentary Location return support for CompleteMultipartUpload #95

Closed daniel-sullivan closed 5 days ago

daniel-sullivan commented 2 weeks ago

Based on AWS documentation: https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html

A location URL should be returned for the newly created object. This implementation adds this field to the output.

Both PathBucket and HostBucket are supported.

codecov-commenter commented 2 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.14%. Comparing base (edd0227) to head (58fe253). Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
gofakes3.go 83.33% 1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #95 +/- ## ========================================== + Coverage 65.99% 66.14% +0.15% ========================================== Files 28 28 Lines 2697 2706 +9 ========================================== + Hits 1780 1790 +10 + Misses 651 649 -2 - Partials 266 267 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud