johannesgerer / buchhaltung

Smart tools for the ledger universe
http://johannesgerer.com/buchhaltung
MIT License
97 stars 8 forks source link

Consider expanding duplicate detection #32

Open ohbadiah opened 6 years ago

ohbadiah commented 6 years ago

I import transactions from both a checking account and a credit card. When I pay the credit card from the checking account, the transaction is imported twice, once for each account:

2017/12/04 ACH WEBSINGLE  XXXXX1234 BARCLAYCARD US   CREDITCARD
    Assets:Checking:PNC                     -1,234.56 USD
    Liabilities:Credit Cards:Barclaycard     1,234.56 USD    ; 

2017/12/02 Payment Received    
    Liabilities:Credit Cards:Barclaycard     1,234.56 USD
    Assets:Checking:PNC                     -1,234.56 USD    ;

I'm unsure if this is best handled through some accounting practice I'm unaware of, or if we might adjust duplicate detection to catch this case.

ohbadiah commented 6 years ago

It occurs to me that duplicate detection may already have much of the functionality I'm looking for, but I might be missing it, because the potential duplicate display may be broken:

------------------- | ------------------------- | ------
Balance             | 165                       | 165.00
Counterparty Status | Verified                  |       
Currency            | USD                       |       
Fee                 | 0                         | 0.00  
From Email Address  | my.friend@gmail.com       |       
Gross               | 165                       | 165.00
Name                | Waldo Emerson             |       
Net                 | 165                       | 165.00
Status              | Completed                 |       
Time                | 19:20:54                  |       
Time Zone           | PST                       |       
To Email Address    | my.email@address.com      |       
Transaction ID      | ASDF1234                  |       
Type                | Payment Received          |       
Date                | 1/3/2018                  |       
formatName          | paypal                    |       
formatVersion       | 2017-US                   |       

Most of the fields in the second transaction are blank. I realize this is probably because they come from different imports and have different source fields, but I'd think the date would line up.

I'll try to look through the duplicate detection code to understand better what's going on.