johannesgerer / buchhaltung

Smart tools for the ledger universe
http://johannesgerer.com/buchhaltung
MIT License
97 stars 8 forks source link

Support aqbanking v6 #40

Open varac opened 5 years ago

varac commented 5 years ago

I'd like to use the new (yet unreleased) aqbanking v6. Some cli arguments changed, so some buchhaltung cmds don't work anymore, i.e.:

varac@aqbanking_container:~/.aqbanking$ buchhaltung setup
3:2019/04/15 13-04-51:gwen(39):args.c:  124: Unknown short option "C"
ERROR: Could not parse arguments main
buchhaltung: callProcess: aqhbci-tool4 "-C" "/home/varac/.aqbanking/xxx-yyy" "adduser" "-t" "pintan" "--context=1" "-b" "xxx" "-u" "zzz" "-s" "..." "-N" "..." "--hbciversion=300" (exit 1): failed

varac@aqbanking_container:~/.aqbanking$ aqhbci-tool4 --help
This is version 5.99.23
Usage: aqhbci-tool4 [GLOBAL OPTIONS] COMMAND [LOCAL OPTIONS]

Global Options:

 [-D PARAM]
 [--cfgdir=PARAM]
   Specify the configuration folder

 [-n]
 [--noninteractive]
   Select non-interactive mode.
   This automatically returns a confirmative answer to any non-critical
   message.

 [-A]
 [--acceptvalidcerts]
   Automatically accept all valid TLS certificate

 [--charset=PARAM]
   Specify the output character set

 [-P PARAM]
 [--pinfile=PARAM]
   Specify the PIN file

 [-h]
 [--help]
   Show this help screen. For help on commands, run aqbanking-cli <COMMAND> --help.
dpaetzel commented 5 years ago

This gets even more important now that PSD2 is in effect (where everyone is forced to update aqbanking to the beta release). Would you accept a PR for this, @johannesgerer ?

dpaetzel commented 4 years ago

Looks like it's not just the names of the options that changed but also their semantics? At least, for me, getsysid's -u option does not expect the number configured by buchhaltung anymore (which is of the form BANKCODE-ACCOUNTNUMBER) but an integer, e.g. a 0 for the first account?

dpaetzel commented 4 years ago

I finally got around to working on this again and I think I managed to fix the problem with the -u option–however, I cannot test whether everything works because my bank responds with something in the lines of “Please upgrade your banking software to a PSD2 compatible version”. I'm working with the aqbanking beta release which should be compatible; I'm not sure whether there is some misconfiguration on my side? Perhaps it has something to do with buchhaltung only supporting PinTAN (and not mTAN, which my bank wants me to use)? Does anybody know something that might help?

I'll probably open a PR soon anyway and let someone else test it as well.

dpaetzel commented 4 years ago

I already tried switching to mTAN after initializing everything with buchhaltung but to no avail so far.

dpaetzel commented 4 years ago

my bank responds with something in the lines of “Please upgrade your banking software to a PSD2 compatible version”

The routine for setting up the connection has changed, at least for my bank, which is why I got this error message. I got it to work now.