search

johannesjo / angular-material-css-vars

Little library to use css variables with @angular/material
https://johannesjo.github.io/angular-material-css-vars/
MIT License
193 stars 31 forks source link

Color of mat-snack-bar not resolved correctly in dark mode #76

Closed dtslvr closed 2 years ago

dtslvr commented 2 years ago

:speaking_head: Foreword

The text of a snack bar is not visible in dark mode, because it is not resolved correctly.

:ghost: Brief Description

The CSS is as follows

.is-dark-theme .mat-snack-bar-container {
  color: 0, 0, 0, 0.87;
}

instead of

.is-dark-theme .mat-snack-bar-container {
  color: rgba(0, 0, 0, 0.87)
}

:pancakes: Action version

angular-material-css-vars: 2.1.0

:police_car: Expected behavior

The text of the snack bar is displayed in dark color (in dark mode).

johannesjo commented 2 years ago

Thanks for reporting this. Would you mind providing a PR to fix this?

pedrojrivera commented 2 years ago

I created a new PR https://github.com/johannesjo/angular-material-css-vars/pull/77 that fixes this issue.

dtslvr commented 2 years ago

I created a new PR #77 that fixes this issue.

Great @pedrojrivera! 👍🏻 I will integrate and test it in https://github.com/ghostfolio/ghostfolio as soon as it is published.

dtslvr commented 2 years ago

77 has been merged for a long time and I have not received a notification 😏

I can confirm that this issue has been fixed. Thanks for your efforts @pedrojrivera!