johannesjo / angular2-promise-buttons

Chilled loading buttons for angular2
https://johannesjo.github.io/angular2-promise-buttons/#demo
MIT License
86 stars 28 forks source link

Set loading state when promise is set after click #12

Closed ghost closed 7 years ago

ghost commented 7 years ago

Loading state wasn't initialized if handleCurrentBtnOnly is true, and promise is added after click.

ghost commented 7 years ago

@johannesjo could you please release a new version with all my changes? I use your module in several projects and I'd like to use the latest code :-)

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.7%) to 94.017% when pulling a6a802f2cd8874efb03a365d0f4de682d5be8f6f on maxkorz:better-handleCurrentBtnOnly into feabf087ab3effe4938c8e587a9ef25e29e34e4f on johannesjo:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 95.726% when pulling 07fe442d92c27242021ceadb1aef76db323396a6 on maxkorz:better-handleCurrentBtnOnly into feabf087ab3effe4938c8e587a9ef25e29e34e4f on johannesjo:master.

johannesjo commented 7 years ago

Thanks again! I release a new version shortly.

ghost commented 7 years ago

My pleasure. If you have any kind of todo list of things you'd like to improve in your module, please share. Maybe I can help you with something.