search

johannesjo / angular2-promise-buttons

Chilled loading buttons for angular2
https://johannesjo.github.io/angular2-promise-buttons/#demo
MIT License
86 stars 28 forks source link

Buttons working with angular5 #16

Closed J4cku closed 7 years ago

J4cku commented 7 years ago

I tried using this lib with Angular 5 RC2, but it does not work since OpaqueToken is already deprecated.

johannesjo commented 7 years ago

Thanks for reporting! Would you be willing to provide a PR for this? The change should be pretty straightfoward. I already implemented this earlier, but threw it out to maintain backwards compatibility for now.

johannesjo commented 7 years ago

@J4cku just tried it with RC3 and it seems to be working again. I would wait until the next stable release until I make the change as we would be loosing angular2 support with the change.

ghost commented 7 years ago

@johannesjo angular 5 has been released. I think it's time to drop angular 2 support

johannesjo commented 7 years ago

I work on it tomorrow! Thanks for mentioning it!

Also @maxkorz would you like to be a collaborator for this repo? You showed so much active support for it and I'm really thankful for it.

Being a collaborator you can push directly to this repository, merge PRs and so forth. At least that's what I think it does :) having another person to be able to do this, would be nice, in case I'm on vacation or otherwise not able to respond quickly.

ghost commented 7 years ago

@johannesjo that would be cool! Yes please :+1:

johannesjo commented 7 years ago

Closing because ng5 support is out now for a while.