search

johannesjo / angular2-promise-buttons

Chilled loading buttons for angular2
https://johannesjo.github.io/angular2-promise-buttons/#demo
MIT License
86 stars 28 forks source link

Fix: downgrade angular to ^4.0.0 for compiling #19

Closed ghost closed 6 years ago

ghost commented 6 years ago

Fixes https://github.com/johannesjo/angular2-promise-buttons/issues/18. As turns out, code compiled with Angular 5 is not compatible with Angular 4, but not vice versa. More info here: https://github.com/angular/angular/issues/19607

Downgrading angular to ^4.0.0 fixes the problem and fixed version works fine with both Angular 4 and Angular 5.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-2.2%) to 94.262% when pulling ca9738d5abf1047f68a33a66318a26325bce2094 on maxkorz:master into 11e5ee46076607ef335946000bcf52b72915288b on johannesjo:master.

johannesjo commented 6 years ago

@maxkorz Thanks for your work again! I'll make another release.

johannesjo commented 6 years ago

@maxkorz in generel please try to follow the angular commit guidelines. So not Fix but fix(scope): ... Otherwise the changelog generation won't work as it should.