search

johannesjo / angular2-promise-buttons

Chilled loading buttons for angular2
https://johannesjo.github.io/angular2-promise-buttons/#demo
MIT License
86 stars 28 forks source link

Angular 6 #22

Closed mits87 closed 6 years ago

mits87 commented 6 years ago

Hi,

current version of angular2-promise-buttons is not compatible with Angular 6. Any plans to upgrade the package?

Thx

johannesjo commented 6 years ago

Thanks for reporting. Are there any errors showing up, when installing the package anyway?

mits87 commented 6 years ago

Yes, there are a few errors like:

ERROR in ./node_modules/angular2-promise-buttons/dist/promise-btn.directive.js Module not found: Error: Can't resolve 'rxjs/Observable' in '/app/node_modules/angular2-promise-buttons/dist' ERROR in ./node_modules/angular2-promise-buttons/dist/promise-btn.directive.js Module not found: Error: Can't resolve 'rxjs/Subscription' in '/app/node_modules/angular2-promise-buttons/dist'

Angular 6 uses a new version of RxJS. Look here: https://www.academind.com/learn/javascript/rxjs-6-what-changed/

johannesjo commented 6 years ago

I'll look into it (probably this weekend). Thank you!

johannesjo commented 6 years ago

I updated the package. Please let me know, if everything works as expected.

mits87 commented 6 years ago

Now works! Thx