search

johannesjo / angular2-promise-buttons

Chilled loading buttons for angular2
https://johannesjo.github.io/angular2-promise-buttons/#demo
MIT License
86 stars 28 forks source link

fix: package.json dependencies #23

Closed jorroll closed 6 years ago

jorroll commented 6 years ago

Hey there,

I was just upgrading my app (which uses angular2-promise-buttons) to angular 6 and received a angular2-promise-buttons@2.1.0" has incorrect peer dependency "@angular/core@6.0.1" warning. Looking at the package.json, you have dependencies locked in for angular v6.0.1. Am I correct in thinking it should instead be "@angular/core": "^6.0.1" ? (the difference being ^)

johannesjo commented 6 years ago

O thanks for reporting. That was not intentional. I'll provide a fix asap.

jorroll commented 6 years ago

No problem. Thanks so much for the library!

jorroll commented 6 years ago

Looks like npm still has the non-fixed version

johannesjo commented 6 years ago

Should be out now. Thanks for pointing it out!