johannesjo / angular2-promise-buttons

Chilled loading buttons for angular2
https://johannesjo.github.io/angular2-promise-buttons/#demo
MIT License
86 stars 28 forks source link

https://github.com/johannesjo/angular2-promise-buttons/issues/34 #44

Closed PieterVanPoyer closed 4 years ago

PieterVanPoyer commented 4 years ago

Try to fix the removal of custom disabled settings. [This could be usefull when working in forms, like form.invalid]

@johannesjo a pull request for https://github.com/johannesjo/angular2-promise-buttons/issues/34

When the button is loading the button is disabled, but, with the @input of the hidden attribute, the state of the outside hidden is tracked. The outside hidden state is set on the component when the promise is resolved and when the hidden input changes.

I think the function name enableButton does not cover the full details anymore, so it should be named different now. But it is public function so it cannot be changed without bumping a major version, so I left the same name.

Please take a look at it. TravisCI seems to be okay!

Kind regards Pieter

johannesjo commented 4 years ago

Thank you very much!