johannesjo / angular2-promise-buttons

Chilled loading buttons for angular2
https://johannesjo.github.io/angular2-promise-buttons/#demo
MIT License
86 stars 28 forks source link

Processing legacy "View Engine" libraries: - angular2-promise-buttons [es2015/esm2015] #91

Open ashikjs opened 1 year ago

ashikjs commented 1 year ago

: Angular 14+ with Iv rendering give warning

Processing legacy "View Engine" libraries:

LeahPike commented 10 months ago

I'm using Angular 17 and unable to build, is there expected to be an update?

error NG6002: 'Angular2PromiseButtonModule' does not appear to be an NgModule class. This likely means that the library (angular2-promise-buttons) which declares Angular2PromiseButtonModule is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

danilobassi8 commented 9 months ago

I'm using Angular 17 and unable to build, is there expected to be an update?

error NG6002: 'Angular2PromiseButtonModule' does not appear to be an NgModule class. This likely means that the library (angular2-promise-buttons) which declares Angular2PromiseButtonModule is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

AFAIK, this library already supports ivy compilation, but the owner didn't deploy a new version 😞

ashikjs commented 9 months ago

@danilobassi8 should we make a replica of this repo and published a new library as extend version and continue improvement.

danilobassi8 commented 9 months ago

@ashikjs the author of this lib @johannesjo is an active GitHub user. Should be easy for him to deploy a new version of this package with latest changes. Maybe he's been busy on other projects. It'd be a pity to let this project die just to avoid clicking the "deploy" button. But as this is stopping us, (and probably a lot of people) from migrating from Angular 15 to 16, forks are going to be created.

ashikjs commented 9 months ago

@danilobassi8 Maybe auther active in other project but he did not release any new version form last 2 years so i don't see any luck.

johannesjo commented 9 months ago

Hey guys. The project isn't a priority any more for me, so I likely won't contribute any code any time soon, but I gladly check any PRs. I can also give access to someone else, if needed.

danilobassi8 commented 9 months ago

@johannesjo we understand that and we appreciate your affords, but in this case the only thing we need is you to deploy the last changes on the master branch to npm!

This PR https://github.com/johannesjo/angular2-promise-buttons/pull/99 that @andrezz-b did is all we need. But you are the only one that can deploy this to npm. The code here on github is unsynced with the one on npm! the last version is from 2 years ago.

If you deploy a new npm version this issue should be closed!

johannesjo commented 9 months ago

@danilobassi8 a new major release is out (untested).

Sorry for the delay everyone!!

worthy7 commented 9 months ago

Is it working for anyone? My angular 17 is still complaining that version 6.0.0 is not an Ivy compilation....

ashikjs commented 9 months ago

Maybe we need new fixed for this one.