search

johannesjo / gnome-shell-extension-window-session-manager

An indicator that let's you save and restore your open apps and the window positions and arrangements over multiple real and virtual displays.
MIT License
91 stars 18 forks source link

[solved] Problem with lwsm config path after update #20

Open thawn opened 4 years ago

thawn commented 4 years ago

The latest update broke the extension for me. It stopped showing any saved sessions and did not seem to do anything when creating new ones.

After looking at the recently changed code, I realized that you changed the hard-coded path to the linux-window-session-manager configuration from .lwsm to .config/lwsm.

I was able to fix the problem by upgrading linux-window-session-manager and moving the configuration from the old to the new location.

sudo npm uninstall -g linux-window-session-manager && sudo npm i -g linux-window-session-manager
mv ~/.lwsm/ ~/.config/lwsm/

However, it would be nice, if the extension also checked the old config location just in case someone (like me) has not upgraded linux-window-session-manager to the latest version yet. Alternatively, give the users a hint what they should do to fix the issue (i.e. some error message or a hint in the readme here and/or on https://extensions.gnome.org)

johannesjo commented 4 years ago

Thanks for reporting this! You're absolutely right! That would have been much better. To be honest: I merged the the PR with this change to lwsm without taking into consideration that this would break the extension. After that I hadn't much time available to spent on the quick fix and this is how we ended up here.

I assume that by now most people have either fixed the issue or uninstalled the extension completely. Don't know if it makes much sense to implement this improvement now, as doing this wrong, will cause additional problems for other people.

thawn commented 4 years ago

@johannesjo I would not be so sure that many people are affected yet. Not everyone manually upgrades the extension as soon as an update becomes available.

I would be more than happy to help test whether the fix works.