search

johannesjo / gnome-shell-extension-window-session-manager

An indicator that let's you save and restore your open apps and the window positions and arrangements over multiple real and virtual displays.
MIT License
91 stars 18 forks source link

Fails to Load - Ubuntu 20.10 (gnome 3.38) #27

Open cytech opened 3 years ago

cytech commented 3 years ago

:speaking_head: Foreword

Thank for taking the time to fill this bug report fully. Without it we may not be able to fix the bug, and the issue may be closed without resolution.

:ghost: Brief Description

Extension Fails to Load - Ubuntu 20.10 (gnome 3.38) error when installing - LG shows "meta is null" journal shows: JS ERROR: Extension lwsm@johannes.super-productivity.com: TypeError: meta is null _createMenuItem@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:184:15 _createMenu/<@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:118:45 _createMenu@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:117:19 _refresh@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:293:10 _init@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:34:10 enable@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:326:12 _buildUi@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:83:5 _init@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:33:10 enable@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:326:12

:pancakes: Action version

Latest installed thru gnome extensions

:tophat: workflow configuration

Ubuntu 20.10 - Gnome 3.38

Steps To Reproduce

Steps to reproduce the behavior:

  1. install extension
  2. fails with error

lwsm is installed and works fine through the command line.

:police_car: Expected behavior

load extension

:heavy_plus_sign: Additional context

possible issue: quick look showed that ST.boxlayout was deprecated in gnome 3.36, removed in 3.38 EDITED: st.boxlayout child meta deprecated/removed

johannesjo commented 3 years ago

Thank you very much for reporting and digging into this! Currently I am pretty busy with other stuff, but I will try to look into it at some point. Meanwhile PRs are welcome.

cytech commented 3 years ago

edit extension.js and change line 80:

let topBox = new St.BoxLayout(); to let topBox = new St.BoxLayout({ x_expand: true, y_expand: true, });

allows the extension to load.

i don't know what else this might effect (no clue about gnome extension programming...) it runs and works, although the dialog looks a little strange.

johannesjo commented 3 years ago

Thank you! Ill try this out next week.

johannesjo commented 3 years ago

I uploaded a new version with the fix you provided. Might take some time until they review it. Thank you very much! Please let me know if the issue persists for some reason.

cytech commented 3 years ago

:thumbsup: