search

johannesjo / ng-fab-form

Convenient forms for Angular with no extra markup? Fabulous!
https://johannesjo.github.io/ng-fab-form
MIT License
172 stars 25 forks source link

expression validation added #57

Closed tushar-borole closed 9 years ago

tushar-borole commented 9 years ago

expression validation added

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 97.22% when pulling 66da7a4cdd1822e41e4affa47a66597246faa142 on tushariscoolster:tushariscoolster-patch-2 into 2aacfc6e0b22552f999c4659b4822aac20568fea on johannesjo:master.

johannesjo commented 9 years ago

Thank you very much!

The correct file for the template is this one though: https://github.com/johannesjo/ng-fab-form/blob/master/src/templates/default-validation-msgs.html And for the directive itself it would be cool, if you could give it a file on its own, like I did for ng-fab-match: https://github.com/johannesjo/ng-fab-form/blob/master/src/ng-fab-match-d.js

And to make it perfect a unit test would also be wonderful. You can checkout the ng-fab-match one. This should give you a good starting point: https://github.com/johannesjo/ng-fab-form/blob/master/src/ng-fab-match-d.spec.js

For development it is easiest if you use grunt serve and grunt test

tushar-borole commented 9 years ago

Let me see when i get time to do it, any way thanks

johannesjo commented 9 years ago

I've to thank. Let me know when you have any further questions.