search

johannesjo / ng-fab-form

Convenient forms for Angular with no extra markup? Fabulous!
https://johannesjo.github.io/ng-fab-form
MIT License
172 stars 25 forks source link

ngFabEnsureExpression with test cases added #58

Closed tushar-borole closed 9 years ago

tushar-borole commented 9 years ago

ngFabEnsureExpression with test cases added

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.09%) to 97.31% when pulling 76280055212ec3edc5ba0aaf16956c8cd115fcb0 on tushariscoolster:master into 2aacfc6e0b22552f999c4659b4822aac20568fea on johannesjo:master.

tushar-borole commented 9 years ago

Am sure, your default-validation-msgs.js dint gt changed, test runned perfectly on my local, i had to delete that file and again need to generate it by grunt.

johannesjo commented 9 years ago

You probably want to develop using the grunt tasks. I suppose the test fails, because the default validation-messages-file (https://github.com/johannesjo/ng-fab-form/blob/master/src/default-validation-msgs.js) is not created properly, which is used for tests and for the bower version.

There also two minor things: The formation of the default-validation-msgs.html shouldn't change and for further development it would be also very helpful to have more helpful commit messages :)

Yo can do the latter by doing a rebase, e.g.:

git rebase -i HEAD~3

Put something descriptive in it like added ngFabEnsureExpression validation directive #56

I would do that myself, but I'm not sure if you would still be listed under the contributors section then.

Thank you very much again. I know that this might seam tiresome, but for future development it is vital to have tests and a useful git history.

tushar-borole commented 9 years ago

Thanks for your suggession; Should i go with by making new pull request now?

johannesjo commented 9 years ago

Yes please! :)

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.09%) to 97.31% when pulling 7ca388b333ab6b4631cf03951e9af4bb0aeb99ce on tushariscoolster:master into 2aacfc6e0b22552f999c4659b4822aac20568fea on johannesjo:master.