search

johannesjo / ng-fab-form

Convenient forms for Angular with no extra markup? Fabulous!
https://johannesjo.github.io/ng-fab-form
MIT License
172 stars 25 forks source link

Watchers are not destroyed #63

Closed GoestaBergfeld closed 9 years ago

GoestaBergfeld commented 9 years ago

I have a directive with a form inside. I have ngFabForms injected. Everything is working fine. But ... after this directive is destroyed (because of a state change via angular-ui-router) I have remaining watchers (identified by ngStats).

johannesjo commented 9 years ago

Thanks for reporting! Interesting, I thought they're usually destroyed automatically when the element is removed. I will check this out.

johannesjo commented 9 years ago

Would you be so kind to check again?

GoestaBergfeld commented 9 years ago

Thanks for your fast reply. I will check it on monday in the office and let you know.

Best regards Gösta

Von meinem iPhone gesendet

Am 24.04.2015 um 17:29 schrieb Johannes Millan notifications@github.com:

Would you be so kind to check again?

— Reply to this email directly or view it on GitHub.

johannesjo commented 9 years ago

Thank you! Have a nice weekend!

GoestaBergfeld commented 9 years ago

Hi, it is working like a charme. All watchers are now removed. Thanks a lot for your quick fix!

johannesjo commented 9 years ago

I have to thank you! :) This could have lead too very very hard to debug problems. Now we're covered on this front.