Reset select elements - Githubissues

johannesjo / ng-fab-form

Convenient forms for Angular with no extra markup? Fabulous!

https://johannesjo.github.io/ng-fab-form

MIT License

172 stars 25 forks source link

Reset select elements #88

Closed adrianhuna closed 8 years ago

adrianhuna commented 8 years ago

One thing I miss in my project is that the reset form button does not work for <select> elements so I added it.

coveralls commented 8 years ago

Coverage decreased (-2.04%) to 96.68% when pulling aa8bbc91090219f6ca3225c09dd02d39164ea708 on adrianhuna:master into baebb313ad808a8f18a94252674d45f56ed8c554 on johannesjo:master.

coveralls commented 8 years ago

Coverage increased (+0.04%) to 98.755% when pulling ff36ba2c82e48c0250aad80960cb907ab2fc2ffc on adrianhuna:master into baebb313ad808a8f18a94252674d45f56ed8c554 on johannesjo:master.

johannesjo commented 8 years ago

Thank you very much for your PR! I think I simply forgot about selects when implementing the reset functionality :)

I'm rerunning the travis build right now. Travis has some hiccups lately unfortunately. There seems to be an issue though. Check my comment in your code.

Could you maybe also check, why the coverage decreased? This should normally not be the case.

coveralls commented 8 years ago

Coverage remained the same at 98.718% when pulling f5d6b60c3638f2a54b8aca58c00ca77d223cb5e3 on adrianhuna:master into baebb313ad808a8f18a94252674d45f56ed8c554 on johannesjo:master.

johannesjo commented 8 years ago

There is still the issue with the button.. :)

adrianhuna commented 8 years ago

Damn, sorry, I didn't notice that tests were failing. But I have one problem - karma:unitSingleRunDist is failing I can't figure out why. Do I need to build dist files first? (I tried to understand grunt file, but I have no experience with grunt...)

Sorry, there are such issues with this PR for such small functionality... Feel free to close it and implement it by yourself if you wish :)

johannesjo commented 8 years ago

Yes. That is something I probably need to change...

You need to run grunt build once. Than all should be fine.

coveralls commented 8 years ago

Coverage remained the same at 98.718% when pulling 0ef280dc3499edb1178f2983c592e86fb9bf4dfe on adrianhuna:master into baebb313ad808a8f18a94252674d45f56ed8c554 on johannesjo:master.

johannesjo commented 8 years ago

FYI: I merged your request and released a new version of ng-fab-form (1.2.9).

Thanks again for your work!

adrianhuna commented 8 years ago

Great! Thank you very for this lib :)