search

johannesjo / super-productivity

Super Productivity is an advanced todo list app with integrated Timeboxing and time tracking capabilities. It also comes with integrations for Jira, Gitlab, GitHub and Open Project.
http://super-productivity.com
MIT License
11.72k stars 907 forks source link

Add desktop notification for exceeded time estimate #191

Closed ZelCloud closed 5 years ago

ZelCloud commented 5 years ago

The pomodoro timer is nice but that workflow style doesn't suit me to well. Instead could we set timers for individual tasks (without break) and have the timer for the task notify us when the allotted time has passed. Also in addition can we get options to have the timer give us a desktop notification or a louder warning I keep missing it if I have music or a video playing in the background.

johannesjo commented 5 years ago

The feature is already kind of implemented. You can set a time estimate on task. If You then set the option "Notify when time estimate was exceeded" under Misc Settings on the Settings Page, you will be notified, once you exceed this estimate. Let me know if this works out for you.

ZelCloud commented 5 years ago

I tried that setting out but just getting the "Time estimate exceeded for x" notification within the app itself isn't too helpful. Having a desktop notification or having the app popup would be far more ideal.

johannesjo commented 5 years ago

I just checked and actually there should be a desktop notification. It works on my installation for linux as well as for windows. Could you provide a little more information on which version you are using and which OS you're on?

KonTy commented 5 years ago

Let me test this as well.

KonTy commented 5 years ago

Just tested it on my Win10 box did not get a system wide notification. I did get a bubble at the bottom of the app but no Windows Notification.

Operating System: Windows 10 Enterprise 64-bit (10.0, Build 17763)

johannesjo commented 5 years ago

Hm that's weird @KonTy thank you for testing this! Could you maybe debug the code on your system? The relevant bits are here: https://github.com/johannesjo/super-productivity/blob/d2b153ccf9664ae6a950dcaea1934ecc5a769790/src/app/core/notify/notify.service.ts#L30-L54 And here: https://github.com/johannesjo/super-productivity/blob/d2b153ccf9664ae6a950dcaea1934ecc5a769790/src/app/features/tasks/store/task.effects.ts#L444

KonTy commented 5 years ago

So I debugged it and everything looks fine. What I figured out is that it actually does create a notification but it is not shows by the system. If I click a notification history the notification is there. So what is happening is that it is raising a silent notification because my focus settings are set to only show notifications for Alarms. So I wonder if it is possible so raise an Alarm? Capture

johannesjo commented 5 years ago

@KonTy Thank you very much for digging into this!

I checked, but I'm afraid that afaik this is not possible at least not without a considerable amount of effort.

KonTy commented 5 years ago

@KonTy Thank you very much for digging into this! I checked, but I'm afraid that afaik this is not possible at least not without a considerable amount of effort.

Perhaps we can add a link to the popup inside the app "Not seeing Desktop Notification?" and link it to a wiki how to disable Focus Mode in Windows.

Another option is tg create a Window which would be Modal Top Most window just like email clients do it for reminders. And make it configurable weather to show it or not.

johannesjo commented 5 years ago

I go with a note about how to check your settings for now. Chances are, that some people don't want to see those notifications if they have configured their system like this.