johannesjo / super-productivity

Super Productivity is an advanced todo list app with integrated Timeboxing and time tracking capabilities. It also comes with integrations for Jira, Gitlab, GitHub and Open Project.
http://super-productivity.com
MIT License
12.06k stars 938 forks source link

Jira Cloud auth only works if you uncheck "Use Personal Access Token instead of password" and then provide a token anyway #2528

Open Nezteb opened 1 year ago

Nezteb commented 1 year ago

Your Environment

Expected Behavior

Jira Cloud auth should work as advertised.

Current Behavior

The only way I can get my Jira Cloud instance to auth successfully within Super Productivity is by providing a Jira Cloud PAT and unchecking the checkbox for using a token, as such:

Screenshot 2023-03-21 at 10 24 50 PM

If I try checking the box and providing a token, it fails.

If I have the box unchecked and provide a password, it fails.

The closest related GitHub issue I can find is https://github.com/johannesjo/super-productivity/issues/2383, but it's more of a sync issue after successfully authenticating.

Steps to Reproduce (for bugs)

  1. Start to connect a Jira Cloud instance.
  2. Check the "Use Personal Access Token instead of password" checkbox.
  3. Provide a Jira Cloud PAT.
  4. The auth will fail.
  5. Uncheck "Use Personal Access Token instead of password".
  6. Try again.
  7. The auth will work, despite you providing a PAT instead of a password.

Can you reproduce this reliably?

I've only tried with a single Jira Cloud instance, but on two different Macbooks and each time has the same result.

Console Output

When the auth fails, just a generic forbidden error shows up in the console.

Error Log (Desktop only)

āÆ cat ~/Library/Logs/superProductivity/main.log
[bat error]: '/Users/noah/Library/Logs/superProductivity/main.log': No such file or directory (os error 2)
github-actions[bot] commented 1 year ago

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

github-actions[bot] commented 1 year ago

Hello there Nezteb! šŸ‘‹

Thank you and congratulations šŸŽ‰ for opening your very first issue in this project! šŸ’–

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. šŸ‘€

For more open ended discussions and/or specific questions, please visit the discussions page. šŸ’–

maytan-cogo commented 1 year ago

Hi @Nezteb, I was integrating with Jira Cloud and got confused about which token to use. Turns out PAT is only available for Data Center and Server versions (https://confluence.atlassian.com/enterprise/using-personal-access-tokens-1026032365.html). For Jira Cloud API tokens are there. (https://support.atlassian.com/atlassian-account/docs/manage-api-tokens-for-your-atlassian-account/)

So I think the "Use Personal Access Token instead of password" is not intended for Jira Cloud integration. The messaging can be improved to indicate this. Better, the checkbox can be disabled if the host is identified as Jira Cloud version (might not be possible though).

github-actions[bot] commented 1 year ago

This issue has not received any updates in 90 days. Please comment, if this still relevant!

hardyoyo commented 3 months ago

It's a super valid issue; please do not auto-close this. It's also an excellent suggestion to change the wording @maytan-cogo. Would you like to submit a PR to make that change? I suggest improving the wording; don't try to make the system smart about Jira Cloud. Ping me here if you can't spare the time to make a PR, and I'll find the time to do it. I'm really happy that this bug was here for me to find, and that I have Super Productivity successfully connected to my Jira Cloud instance. Thank you so much, @Nezteb!

hardyoyo commented 3 months ago

OH, this issue is already closed. Darn bot. It should be re-opened.