johannesjo / super-productivity

Super Productivity is an advanced todo list app with integrated Timeboxing and time tracking capabilities. It also comes with integrations for Jira, Gitlab, GitHub and Open Project.
http://super-productivity.com
MIT License
8.67k stars 753 forks source link

Shortcut: 'Show & Focus/Hide Sidenav' not working as expected #3084

Closed AngeloThys closed 3 months ago

AngeloThys commented 3 months ago

Your Environment

Expected Behavior

When pressing the related keybinding when:

A. Sidenav is not shown

Show and focus the sidenav.

B. Sidenav is shown

Hide the sidenav.

Current Behavior

Sidenav is always shown. When the keybind is used, sidenav gains focus. It does not hide the sidenav on second use.

Steps to Reproduce (for bugs)

  1. Activate keybinding.
  2. Focus sidenav.
  3. Activate keybinding.
  4. Nothing happens.

Can you reproduce this reliably?

Yes. It happens consistently.

Console Output

image

The first 2 [layout] outputs in the console are executed with the console closed, whilst the remaining are executed with the console open. See edge case

Error Log (Desktop only)

Not provided.

Edge case (?)

When performing the same steps with the console open (shift+ctrl+i), the keybinding for the shortcut: 'Show & Focus/Hide Sidenav' works as expected.

github-actions[bot] commented 3 months ago

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

johannesjo commented 3 months ago

Hey there! When the app window is very wide the navigation is always shown.

AngeloThys commented 2 months ago

@johannesjo so it has to do with the screen being smaller when the console is open rather than an actual bug. Good to know! Thanks