johannesjo / super-productivity

Super Productivity is an advanced todo list app with integrated Timeboxing and time tracking capabilities. It also comes with integrations for Jira, Gitlab, GitHub and Open Project.
http://super-productivity.com
MIT License
8.66k stars 753 forks source link

Worklog and Quick History list tasks that have not been worked on #3122

Closed Jagdfalke closed 2 months ago

Jagdfalke commented 2 months ago

Your Environment

Expected Behavior

A task should only appear in the Worklog or Quick History when time has been tracked for the task or if it has been checked as completed.

Current Behavior

When you create a task and you don't track any time and don't mark ist as completed, it will still appear in the Worklog and Quick History on the day you created it.

Steps to Reproduce (for bugs)

  1. Create a task and don't track any time: image
  2. Go to either Quick History or Worklog and drill down on the current day
  3. The task will appear even though no time has been tracked: image

Can you reproduce this reliably?

Yes, 100% of the time

github-actions[bot] commented 2 months ago

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

johannesjo commented 2 months ago

Thanks for opening this up!

For the worklog this is necessary since otherwise there would be no way to restore these tasks and they will be just lost in the void. So I'd prefer not to change the behavior for those.

For the quick history my suggestion would be as follows: We don't show tasks that have no time spent for the day, unless they have been marked as done on that day. What do you think @Jagdfalke ?

Jagdfalke commented 2 months ago

For the quick history my suggestion would be as follows: We don't show tasks that have no time spent for the day, unless they have been marked as done on that day. What do you think @Jagdfalke ?

Yes, I think this would work.

Why isn't this possible for the worklog though?

johannesjo commented 2 months ago

Imagine an archived undone sub task of a done task where you have some documents attached or some interesting notes. If we don't display it in the worklog somewhere, it is like it is never existed, just taking up disk space.

Jagdfalke commented 2 months ago

Alright, understood. But sub-tasks are still connected to their parent when the parent is marked as 'done', aren't they?

Wouldn't it be possible to add 'undone' sub-tasks to the worklog on the day when their parent was marked as 'done'? That way they wouldn't be lost and it makes more sense to display them on the day their parent was marked as 'done', implying that they are done as well.

johannesjo commented 2 months ago

Yes and yes I agree, that would make more sense. I just checked and it seems that tasks are marked as done anyway when they're moved to the archive. Only problem then might be legacy data where not all archive tasks are marked as done. But it is probably OK to ignore that.

johannesjo commented 2 months ago

This should work as expected now, hopefully. Please reopen if it doesn't :)