search

johannesjo / super-productivity

Super Productivity is an advanced todo list app with integrated Timeboxing and time tracking capabilities. It also comes with integrations for Jira, Gitlab, GitHub and Open Project.
http://super-productivity.com
MIT License
8.66k stars 753 forks source link

Template strings not correctly relaced when I snooze reminder in German localisation #3147

Closed rklec closed 2 months ago

rklec commented 2 months ago

Your Environment

Expected Behavior

eplace the strings "title" and "start" with the values, likely there is a space too much.

Current Behavior

grafik

Steps to Reproduce (for bugs)

Setup/use a reminder that pops up that you need to do sth. Snooze in/for 10 min. e.g.

Can you reproduce this reliably?

Not tested, but I guess

Console Output

nothing relevant

Error Log (Desktop only)

not relevant

github-actions[bot] commented 2 months ago

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

rklec commented 2 months ago

I have created a PR to fix the immediate issue (there are many more broken strings), but maybe you can expand some unit tests or so catch issues like this? Or does the translation platform display a preview of possible content values?

Jagdfalke commented 2 months ago

Uh oh, this one is on me. I've completed the German translation for the current version 8.0.5. The translation tool does not have a preview for variable content. I tried to account for this manually but apparantly this slipped past my attention.

rklec commented 2 months ago

Which tool do you even use? The contrib guide does not mention an online tool or so - maybe introducing such one (even syntax highlighting the parts could help), would help?

johannesjo commented 2 months ago

Thank you very much for the fix!