johannesjo / super-productivity

Super Productivity is an advanced todo list app with integrated Timeboxing and time tracking capabilities. It also comes with integrations for Jira, Gitlab, GitHub and Open Project.
http://super-productivity.com
MIT License
8.65k stars 753 forks source link

Sidenav is hidden after double pressing Escape even for wide screens and not coming back #3204

Open nfrid opened 3 weeks ago

nfrid commented 3 weeks ago

Your Environment

Expected Behavior

On wide screen mode the Sidenav always visible and you can't hide it.

Current Behavior

After focusing the navigation menu and pressing Escape several times, the menu becomes hidden without any way to toggle it on.

Keyboard shortcut for toggling the Sidenav does nothing, the only way to bring it back is either make the window narrow and wide again so the state updates accordingly or go into focus mode and back.

Steps to Reproduce (for bugs)

  1. Make the window wide enough (so we can't toggle the Sidenav).
  2. Focus the Sidenav (via shortcut or just clicking on it).
  3. Press Escape a couple times in a row.
  4. ???
  5. 💀

Can you reproduce this reliably?

Every time I do these steps.

Console Output

image

Error Log (Desktop only)

No errors in the logs...

github-actions[bot] commented 3 weeks ago

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

github-actions[bot] commented 3 weeks ago

Hello there nfrid! 👋

Thank you and congratulations 🎉 for opening your very first issue in this project! 💖

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀

For more open ended discussions and/or specific questions, please visit the discussions page. 💖

johannesjo commented 2 weeks ago

I tried to fix this, but was unable to find a good work around. The issue is with the underlying material component. I hope to revisit this, once I get to update all those (will be a lot of work, since they changed everything from the ground up).

Jagdfalke commented 1 week ago

I can reproduce the issue.

However I can also let the sidebar reappear if I snap the window to one side. Can you try this?

While this is not very convenient, it should be at least a viable workaround for the moment and makes this issue less severe.