johannesjo / super-productivity

Super Productivity is an advanced todo list app with integrated Timeboxing and time tracking capabilities. It also comes with integrations for Jira, Gitlab, GitHub and Open Project.
http://super-productivity.com
MIT License
8.65k stars 753 forks source link

Deleting or finishing tasks with tagged subtasks causes repairable corruption #3205

Closed AZeed18 closed 4 days ago

AZeed18 commented 3 weeks ago

Your Environment

Expected Behavior

Current Behavior

Can you reproduce this reliably?

Yes, it always happens.

Error Log (Desktop only)

%USERPROFILE%\AppData\Roaming\superProductivity\logs\main.log

No changes in log file

Solution to Corruption

Get the task out of worklog

github-actions[bot] commented 3 weeks ago

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

github-actions[bot] commented 3 weeks ago

Hello there AZeed18! 👋

Thank you and congratulations 🎉 for opening your very first issue in this project! 💖

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀

For more open ended discussions and/or specific questions, please visit the discussions page. 💖

AZeed18 commented 3 weeks ago

PS: This problem never happened, but now it happens everytime and does NOT get fixed by restoring task from backlog anymore

johannesjo commented 2 weeks ago

Thanks for reporting. Does this happen with the most recent version 8.0.7 as well?

AZeed18 commented 2 weeks ago

Yes, the data still gets corrupted

Actually the problem gets fixed when I get those newly archived tasks out of worklog although previously archived tasks of same type are still there

AZeed18 commented 2 weeks ago

Can you reproduce this?

johannesjo commented 2 weeks ago

Can you reproduce this?

Yes! Thank you! I'll work on a fix!

johannesjo commented 2 weeks ago

Will be fixed with the next release (hopefully :))!

AZeed18 commented 1 week ago

Thanks for trying! The problem still exists in 8.0.9 :(

AZeed18 commented 1 week ago

It is worth noting that the problem got fixed when I ignored the corruption, made an export, imported it, then click ok here:

image

johannesjo commented 1 week ago

Thanks for trying! The problem still exists in 8.0.9 :(

Are you able to reproduce the issue again or is everything fine after applying the data repair?

AZeed18 commented 1 week ago

So far, the issue is fixed and everything is fine!

I don't know why I needed to corrupt and repair though, maybe because I use another app to sync the sync file with another device

johannesjo commented 1 week ago

Then I am closing this! Please let me know, if there are additional problems!

AZeed18 commented 1 week ago

The problem is not fixed, but I think I figured out what needs to be fixed...

Deleting tasks with tagged subtasks gives the same error and states that the deleted task ID (assumption) is missing from its tag, which gets fixed by repairing

Probably that's another issue since you fixed the same problem with archiving

johannesjo commented 5 days ago

@AZeed18 can you provide me with the exact steps required for reproducing this? I tried several variations but was unable to cause another error.

AZeed18 commented 5 days ago

Just delete a task which has a tagged subtask or more:

image

It is worth mentioning that going to the corrupted tag shows this fatal error:

image

johannesjo commented 5 days ago

Thank you very much once more! Hopefully was able to fix this! :) The fix will be included in the next release.

AZeed18 commented 4 days ago

You're welcome! I will let you know if there are any issues.