johannesjo / super-productivity

Super Productivity is an advanced todo list app with integrated Timeboxing and time tracking capabilities. It also comes with integrations for Jira, Gitlab, GitHub and Open Project.
http://super-productivity.com
MIT License
8.65k stars 753 forks source link

Error: 'zoomFactor' must be a double greater than 0.0 #3218

Closed rokbot closed 1 week ago

rokbot commented 1 week ago

Steps to Reproduce

  1. open the app.
  2. (Zoom out) until you raise the error.

Console Output

global-error-handler.class.ts:24 GLOBAL_ERROR_HANDLER Error: 'zoomFactor' must be a double greater than 0.0
    at n.zoomBy (ui-helper.service.ts:39:15)
    at n.handleKeyDown (shortcut.service.ts:180:31)
    at n.onKeyDown (app.component.ts:205:27)
    at app.component.ts:61:14
    at Bk (core.mjs:15767:16)
    at k (core.mjs:15802:22)
    at HTMLDocument.<anonymous> (platform-browser.mjs:464:13)
    at U.invokeTask (zone.js:406:31)
    at Object.onInvokeTask (core.mjs:26343:33)
    at U.invokeTask (zone.js:405:60)

Meta Info

META: SP8.0.9 Electron – en-US – Linux x86_64 – Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) superProductivity/8.0.9 Chrome/122.0.6261.156 Electron/29.4.3 Safari/537.36

Stacktrace

Error: 'zoomFactor' must be a double greater than 0.0
    at n.zoomBy (file:///usr/lib/superproductivity/app.asar/dist/main.1250ffbe73777cdd.js:1:896719)
    at n.handleKeyDown (file:///usr/lib/superproductivity/app.asar/dist/main.1250ffbe73777cdd.js:1:900764)
    at n.onKeyDown (file:///usr/lib/superproductivity/app.asar/dist/main.1250ffbe73777cdd.js:1:2105191)
    at file:///usr/lib/superproductivity/app.asar/dist/main.1250ffbe73777cdd.js:1:2108408
    at Bk (file:///usr/lib/superproductivity/app.asar/dist/main.1250ffbe73777cdd.js:1:4058785)
    at k (file:///usr/lib/superproductivity/app.asar/dist/main.1250ffbe73777cdd.js:1:4058924)
    at HTMLDocument.<anonymous> (file:///usr/lib/superproductivity/app.asar/dist/main.1250ffbe73777cdd.js:1:39422)
    at U.invokeTask (file:///usr/lib/superproductivity/app.asar/dist/polyfills.8db5726c6ae16cfe.js:1:7290)
    at Object.onInvokeTask (file:///usr/lib/superproductivity/app.asar/dist/main.1250ffbe73777cdd.js:1:4087965)
    at U.invokeTask (file:///usr/lib/superproductivity/app.asar/dist/polyfills.8db5726c6ae16cfe.js:1:7211)

Actions Before Error

1718314553036: [FocusMode] Cancel Focus Session 
1718314553040: [FocusMode] Set focus session elapsed time 
1718314553041: [Task] UnsetCurrentTask 
1718314582901: [Layout] Hide SideBar (2) 
1718315505752: [FocusMode] Set focus session elapsed time 
1718315505884: [SP_ALL] Load(import) all data 
1718315505887: [SP_ALL] All Data was loaded 
1718315563653: [FocusMode] Set focus session elapsed time 
1718315563816: [SP_ALL] Load(import) all data 
1718315563819: [SP_ALL] All Data was loaded 
1718315585708: [WorkContext] Set Active Work Context 
1718315585710: [Task] SetSelectedTask 
1718315588126: [WorkContext] Set Active Work Context 
1718315588130: [Task] SetSelectedTask 
1718315857039: [FocusMode] Set focus session elapsed time 
1718315857170: [SP_ALL] Load(import) all data 
1718315857173: [SP_ALL] All Data was loaded 
1718315956360: [FocusMode] Set focus session elapsed time 
1718315956585: [SP_ALL] Load(import) all data 
1718315956588: [SP_ALL] All Data was loaded 
1718315978229: [Layout] ToggleShow Notes 
1718315978231: [Task] SetSelectedTask 
1718315983011: [Layout] ToggleShow Notes (2) 
1718315983013: [Task] SetSelectedTask 
1718315984471: [Layout] ToggleShow Notes (2) 
1718315984471: [Task] SetSelectedTask 
1718315985549: [Layout] ToggleShow Notes 
1718316323136: [FocusMode] Set focus session elapsed time 
1718316323497: [SP_ALL] Load(import) all data 
1718316323503: [SP_ALL] All Data was loaded
github-actions[bot] commented 1 week ago

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

github-actions[bot] commented 1 week ago

Hello there rokbot! 👋

Thank you and congratulations 🎉 for opening your very first issue in this project! 💖

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀

For more open ended discussions and/or specific questions, please visit the discussions page. 💖

Jagdfalke commented 1 week ago

On Windows I am unable to reproduce this issue. Do you zoom out in the main window or any other view?

johannesjo commented 1 week ago

Was able to fix to reproduce and fix this (breaks if you zoom via keyboard shortcut). Thank you!!!