johannesjo / super-productivity

Super Productivity is an advanced todo list app with integrated Timeboxing and time tracking capabilities. It also comes with integrations for Jira, Gitlab, GitHub and Open Project.
http://super-productivity.com
MIT License
12k stars 933 forks source link

Error: Tag length should not change on re-order #3636

Closed Juni4567 closed 3 weeks ago

Juni4567 commented 3 weeks ago

Steps to Reproduce

  1. Drag any tag up or down and you'll see this error

Error Log (Desktop only)

Console Output

Meta Info

META: SP10.0.11 Electron – en-US – Win32 – Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) superProductivity/10.0.11 Chrome/128.0.6613.162 Electron/32.1.2 Safari/537.36

Stacktrace

file:///C:/Program%20Files/WindowsApps/53707johannesjo.SuperProductivity_10.0.11.0_x64__ch45amy23cdv6/app/resources/app.asar/dist/browser/src/app/features/tag/store/tag.reducer.ts:367:12
function (file:///C:/Program%20Files/WindowsApps/53707johannesjo.SuperProductivity_10.0.11.0_x64__ch45amy23cdv6/app/resources/app.asar/dist/browser/node_modules/@ngrx/store/fesm2022/ngrx-store.mjs:1600:21)
createFeatureReducerFactory (file:///C:/Program%20Files/WindowsApps/53707johannesjo.SuperProductivity_10.0.11.0_x64__ch45amy23cdv6/app/resources/app.asar/dist/browser/node_modules/@ngrx/store/fesm2022/ngrx-store.mjs:386:13)
combination (file:///C:/Program%20Files/WindowsApps/53707johannesjo.SuperProductivity_10.0.11.0_x64__ch45amy23cdv6/app/resources/app.asar/dist/browser/node_modules/@ngrx/store/fesm2022/ngrx-store.mjs:346:30)
reducer (file:///C:/Program%20Files/WindowsApps/53707johannesjo.SuperProductivity_10.0.11.0_x64__ch45amy23cdv6/app/resources/app.asar/dist/browser/src/app/root-store/meta/action-logger.reducer.ts:14:11)
reducer (file:///C:/Program%20Files/WindowsApps/53707johannesjo.SuperProductivity_10.0.11.0_x64__ch45amy23cdv6/app/resources/app.asar/dist/browser/src/app/root-store/meta/undo-task-delete.meta-reducer.ts:128:11)
Array.isArray (file:///C:/Program%20Files/WindowsApps/53707johannesjo.SuperProductivity_10.0.11.0_x64__ch45amy23cdv6/app/resources/app.asar/dist/browser/node_modules/@ngrx/store/fesm2022/ngrx-store.mjs:376:13)
reduceState (file:///C:/Program%20Files/WindowsApps/53707johannesjo.SuperProductivity_10.0.11.0_x64__ch45amy23cdv6/app/resources/app.asar/dist/browser/node_modules/@ngrx/store/fesm2022/ngrx-store.mjs:569:11)
_tryNext (file:///C:/Program%20Files/WindowsApps/53707johannesjo.SuperProductivity_10.0.11.0_x64__ch45amy23cdv6/app/resources/app.asar/dist/browser/node_modules/rxjs/_esm2015/internal/operators/scan.js:48:20)
_next (file:///C:/Program%20Files/WindowsApps/53707johannesjo.SuperProductivity_10.0.11.0_x64__ch45amy23cdv6/app/resources/app.asar/dist/browser/node_modules/rxjs/_esm2015/internal/operators/scan.js:41:18)

Actions Before Error

1730105319191: [Layout] Hide AddTaskBar 
1730105325140: [Tag] Add Tag 
1730105325140: [Persistence] Save to DB 
1730105325140: [Task] Update Task Tags 
1730105325141: [Persistence] Save to DB (3) 
1730105326511: [Task] Update Task Tags 
1730105326512: [Persistence] Save to DB (3) 
1730105328917: [Task] Update Task Tags 
1730105328918: [Persistence] Save to DB (3) 
1730105336644: [Tag] Delete Tag 
1730105336645: [Persistence] Save to DB 
1730105336645: [Task] Remove Tags from all Tasks 
1730105336672: [Persistence] Save to DB (2) 
1730105336770: [Task] Delete Tasks 
1730105336827: [Persistence] Save to DB (3) 
1730105523605: [Task] Schedule 
1730105523607: [Persistence] Save to DB (2) 
1730105523607: [Task] Update Task 
1730105523607: [Planner] Remove Task From Days 
1730105523608: [Persistence] Save to DB (2) 
1730105523608: [Task] Update Task Tags 
1730105523608: [Persistence] Save to DB (3) 
1730105556200: [Task] Delete Task 
1730105556203: [Persistence] Save to DB (3) 
1730105556203: [Task] UnsetCurrentTask 
1730105562094: [WorkContext] Set Active Work Context 
1730105562140: [Task] SetSelectedTask 
1730105565869: [WorkContext] Set Active Work Context 
1730105565895: [Task] SetSelectedTask 
1730105574814: [Tag] Update Tag Order
github-actions[bot] commented 3 weeks ago

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

github-actions[bot] commented 3 weeks ago

Hello there Juni4567! 👋

Thank you and congratulations 🎉 for opening your very first issue in this project! 💖

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀

For more open ended discussions and/or specific questions, please visit the discussions page. 💖

johannesjo commented 3 weeks ago

Duplicate of #3559