search

johanneslumpe / react-native-gesture-recognizers

Gesture recognizer decorators for react-native
MIT License
366 stars 55 forks source link

Android Support? #3

Open peterlazar1993 opened 8 years ago

peterlazar1993 commented 8 years ago

It would be awesome if it has android support.

rclai commented 8 years ago

This should already work for Android?

KalebPortillo commented 8 years ago

Its not working on Android, any idea why?

johanneslumpe commented 8 years ago

@KalebPortillo there is no platform specific code afaik. Can you be more specific than "it does not work"?

KalebPortillo commented 8 years ago

the swipes are not detected in android... I was using the same code for both platforms

johanneslumpe commented 8 years ago

@KalebPortillo oh that's weird. It is very much possible that things have changed between now and when I wrote this proof of concept. I haven't been using RN much recently because my day job does not permit it, so I couldn't really tell right off the bat. If you feel like investigating, that would be welcome!

jayshah123 commented 8 years ago

When I swipe my finger left at a decent swiping speed, I get following log -> ' vx : ', 1.9513594000461165e-8, ' dy : ', -1.333343505859375, ' initialVelocityThreshold : ', 0.7, ' verticalThreshold = ', 10

As you see the velocity magnitude is waaayyyyy too small to be compared with threshold and validHorizontal always turns out to be false. Trying to get to the bottom of it .

jayshah123 commented 8 years ago

looks like fix should land in rn 0.34 as per https://github.com/facebook/react-native/pull/8199