search

johanneslumpe / redux-history-transitions

history transitions based on arbitrary actions
MIT License
167 stars 10 forks source link

Update README to correct parameters of the meta transition function. #8

Closed wdhorton closed 8 years ago

wdhorton commented 8 years ago

This tripped me up a few times, so I decided to send in a PR to clear it up. The README still has the parameters of the meta transition function as (state, action), but the current version of this package and the example use (prevState, nextState, action).

johanneslumpe commented 8 years ago

Ha, good catch! Thanks!

wdhorton commented 8 years ago

No problem! Thanks for your work on this, it solves a real need and I'm using it fairly often now.

johanneslumpe commented 8 years ago

That's good to hear :) I really want to tackle https://github.com/johanneslumpe/redux-history-transitions/issues/3 soon too - to reduce the boilerplate of having to check whether an action succeeded or not. Maybe next week..