search

johanneslumpe / redux-history-transitions

history transitions based on arbitrary actions
MIT License
167 stars 10 forks source link

Include meta.done property in transition.success example #9

Closed wimpyprogrammer closed 8 years ago

wimpyprogrammer commented 8 years ago

Thanks for this great library! I think it will be very useful on my project.

I really like the options for transition.success and transition.failure. But it took me a while to implement in my project because the example in README.md doesn't specify the meta.done: true option. Even though the reliance on meta.done is mentioned in the paragraph above, it didn't click for me until I started picking through the source code to debug.

This pull request will amend the transition.success example to specify that property.

johanneslumpe commented 8 years ago

@wimpyprogrammer sorry for not seeing this earlier! Thanks :)