search

johannesmayer / SIRF

Main repository for the CCPPETMR software
http://www.ccppetmr.ac.uk
Other
2 stars 0 forks source link

cmake finds Gadgetron shared libraries #27

Closed paskino closed 3 years ago

paskino commented 4 years ago

This requires a very recent varsion of Gadgetron where they fixed an import problem.

From this commit this is fixed. Otherwise it'll require a patch to the file after build (or install) which is not so trivial.

paskino commented 3 years ago

I’m trying to build Gadgetron master. It seems that Gadgetron requires C++17 standard, which seems to be implemented in GCC >=9. https://github.com/gadgetron/gadgetron/issues/925#issuecomment-763676235 or https://github.com/SyneRBI/SIRF-SuperBuild/pull/438#issuecomment-767377380 I’m not sure of this, https://gcc.gnu.org/projects/cxx-status.html#cxx17 seems to indicate GCC 8 to be the one?

Although we’ve been used to backward compatible GCC compilers, this time it’s not the case. Apparently there are a few differences that unfortunately impact on us indirectly: NIFTYREG fails to build, ITK is even better and replies error: #error "Dunno about this gcc". And I still haven’t made it to STIR or SIRF.

So I was wondering how to proceed. What I want to know from you is, what do you need? It may (MAY) be easy enough to dockerize Gadgetron, but is that what you need? I believe you need a built version of Gadgetron and its includes and libraries to link to.

johannesmayer commented 3 years ago

Hey Edo, thanks for all this effort.

You're correct, I need a built version of Gadgetron to include the libraries so I can use their gridding code.

But it would be fine to build the commit with the include problems fixed that you linked above. Master is not required.

paskino commented 3 years ago

Once https://github.com/SyneRBI/SIRF-SuperBuild/pull/488 is merged you just need to merge this PR into your branch and then merge master into your branch and it should be ready to be merged into SIRF master.