search

johannesschobel / dingoquerymapper

Uses Dingo/API Request Query Parameters to filter Laravel Models
MIT License
12 stars 6 forks source link

[proposal] support new laravel versions #4

Closed asadhshujau closed 7 years ago

asadhshujau commented 7 years ago

Hence this looks really simple to use

How about adding support for laravel 5.4 ? :)

johannesschobel commented 7 years ago

Can you make a PR? ;)

Am 11.04.2017 8:54 vorm. schrieb "Asadh Shujau" notifications@github.com:

Hence this looks really simple to use

How about adding support for laravel 5.4 ? :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/johannesschobel/dingoquerymapper/issues/4, or mute the thread https://github.com/notifications/unsubscribe-auth/AI_pNmI4DoTBM0eH-DfADUzkR7SjjFNiks5ruyO1gaJpZM4M5sMN .

asadhshujau commented 7 years ago

i cloned this locally and only changed compser.json laravel/framework version to 5.4.* and it works

johannesschobel commented 7 years ago

I thought so, as the package does not rely on L5.1 specific features...

I hope to add some new features in the future, like building the collections from a Builder and so on.. if you have any suggestions, let me know..

Cheers

Am 11.04.2017 10:06 vorm. schrieb "Asadh Shujau" notifications@github.com:

i cloned this locally and only changed compser.json laravel/framework version to 5.4.* and it works

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/johannesschobel/dingoquerymapper/issues/4#issuecomment-293182865, or mute the thread https://github.com/notifications/unsubscribe-auth/AI_pNuw9BLEgrVP5qu8F_Oww1KScfWY3ks5ruzSKgaJpZM4M5sMN .

johannesschobel commented 7 years ago

should by resolved by #6