search

johannessteu / neos-development-collection

The unified repository containing the Neos core packages, used for Neos development.
GNU General Public License v3.0
0 stars 0 forks source link

FrontendNodeRoutePartHandler throws exception #882

Closed johannessteu closed 8 years ago

johannessteu commented 8 years ago

Jira issue originally created by user sregniet:

https://github.com/neos/neos/blob/master/Classes/TYPO3/Neos/Routing/FrontendNodeRoutePartHandler.php#L421 -> the condition sequence has to be switched (check instanceof NodeInterface first), since $node->getParent() may return null.

In some occasions (presumably if there is no translation, but the Seo Package tries to render an hreflang tag), I get an exception (with Neos 2.3): "Fatal error: Call to a member function getParentPath() on null in FrontendNodeRoutePartHandler.php on line 421"

Jira-URL: https://jira.neos.io/browse/NEOS-1880

johannessteu commented 8 years ago

Comment created by @johannessteu:

hey [~regniets],

thanks for reporting this! Would you mind to create a PR for this? Guess this could also be fixed in lower versions, not just 2.3. If you there are any questions how to create a PR on github or something feel free to ping me here or in Slack @stolle

johannessteu commented 8 years ago

Comment created by sregniet:

Hey [~stolle], i created a fork and a commit, but i am not sure, which base to take for the PR: https://github.com/regniets/neos-development-collection/commit/caf9c94a8057d657e867739a366deeb96c18b639

johannessteu commented 8 years ago

Comment created by @johannessteu:

[~regniets] i think 2.1 is good!