search

johannesvollmer / exrs

100% Safe Rust OpenEXR file library
Other
154 stars 24 forks source link

Failed unzipping EXR #210

Closed fursund closed 1 year ago

fursund commented 1 year ago

Tried loading this EXR with 1.5.3 and it fails unzipping: https://drive.google.com/file/d/1JNZJtrko3U50p5B4e0figjqFOWiQDjFj/view?usp=sharing

johannesvollmer commented 1 year ago

Thanks for sharing! :) I'll have a look

johannesvollmer commented 1 year ago

The file seems to be valid, but the zip-decoder reports an adler mismatch. I'll forward the issue to the zip-decoder.

fursund commented 1 year ago

Is there a simple way to use something else than zune? Seems we have a bunch of issues with it.

johannesvollmer commented 1 year ago

Unfortunately there is no such mechanism in place right now. We'd have to switch to another dependency in the library and then release a new version of exr.

It cloud be possible to allow all users of exrs to supply their own zlib decoder functions, but I'm not sure whether that's the right way - I don't want toput the label "fast but not always correct" on one of the options. All options should work. The zune-deflate author usually replies and fixes issues quickly. If more issues surface after this one is fixed, then we could consider replacing the dependency.

etemesi254 commented 1 year ago

Hi, fixed.

And updated, should happen transpalently

fursund commented 1 year ago

Great thanks!

etemesi254 commented 1 year ago

And sorry for the bug

Wish we could all write perfect software :)

But would love to ask for permission to add the specific zip file into the test harness to catch such cases in the future

fursund commented 1 year ago

Ah no worries! Thanks for fixing so promptly! No problem if you use the data as test case!

Shnatsel commented 1 year ago

I believe this issue is fixed and should be closed.

johannesvollmer commented 1 year ago

Yes. We could always reopen it if necessary.