Don't use flume's default features

johannesvollmer / exrs

100% Safe Rust OpenEXR file library

Other

149 stars 22 forks source link

Don't use flume's default features #219

Closed fintelia closed 10 months ago

fintelia commented 10 months ago

Notably, this eliminates a dependency on syn which improves compile time.

johannesvollmer commented 10 months ago

Thank you for investigating and taking the time :) I'll prepare the release soon :)

DJMcNab commented 9 months ago

We've discovered in https://github.com/linebender/vello/pull/360 that this PR is breaking, specifically because it loses the nanorand dependency of flume, which transitively means that the js feature of getrandom is no longer enabled.

All-in-all, I think this is still fine as a minor release - nanorand was wrong here, and we were wrong for (unknowingly) depending on this behaviour. But in case anyone else comes digging, this is why

johannesvollmer commented 9 months ago

thanks for the heads-up! :)