search

johannesvollmer / exrs

100% Safe Rust OpenEXR file library
Other
154 stars 24 forks source link

bump flume version for spin-rs dependency update #220

Closed okey closed 1 year ago

okey commented 1 year ago

flume depends on spin-rs, and spin-rs prior to v0.9.8 has a concurrency bug

flume updated its spin dependency in https://github.com/zesterer/flume/commit/9f67d0d2b4c57844f3b5d6ec26e6d9f4446dae93 and released that as v0.11.0 in https://github.com/zesterer/flume/commit/ee6fe6adb98856edbda47d1cc867cbc255ff0d88

johannesvollmer commented 1 year ago

Thanks for taking the time to contribute and summarize the situation :) Looks good, I'll merge that and publish a new version

okey commented 1 year ago

@johannesvollmer Regarding the rust version check failure:

Locally, rm -f Cargo.lock && cargo-msrv verify and rm -f Cargo.lock && cargo +1.59.0-x86_64-unknown-linux-gnu update && cargo-msrv verify succeed but rm -f Cargo.lock && cargo update && cargo-msrv verify fails, probably because image 0.24.4 requires rust 1.61.0

This PR could be updated to raise the MSRV of exrs to 1.61.0, or by removing cargo update from the GitHub workflow, or by pinning the image dependency more strictly. What do you think?

johannesvollmer commented 1 year ago

The MSRV check failed a few times now, not only on this PR. Thanks for you insights. Seeing that the image crate uses a newer version than we do, we should raise our MSRV to 1.61.0. If you want to contribute that, that would be awesome :)

okey commented 1 year ago

@johannesvollmer I have updated this PR to raise the exrs MSRV to 1.61.0

johannesvollmer commented 1 year ago

Thanks for your time and efforts :)